fix(base-driver): Make sure we never mutate incoming args (#16670)

appium · Mar 28, 2022 · c63e9bf · c63e9bf
1 parent 25fab42
commit c63e9bf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/base-driver/lib/basedriver/core.js b/packages/base-driver/lib/basedriver/core.js
@@ -155,7 +155,7 @@ class DriverCore {
      if (!this._log) {
        const instanceName = `${this.constructor.name}@${node
          .getObjectId(this)
-         .substring(0, 8)}`;
+         .substring(0, 4)}`;
        this._log = logger.getLogger(() =>
          this.sessionId
            ? `${instanceName} (${this.sessionId.substring(0, 8)})`

diff --git a/packages/base-driver/lib/basedriver/driver.js b/packages/base-driver/lib/basedriver/driver.js
@@ -233,11 +233,11 @@ export class BaseDriverCore extends DriverCore {
 
     this.log.debug();
 
-    const originalCaps = [
+    const originalCaps = _.cloneDeep([
       w3cCapabilities,
       w3cCapabilities1,
       w3cCapabilities2,
-    ].find(isW3cCaps);
+    ].find(isW3cCaps));
     if (!originalCaps) {
       throw new errors.SessionNotCreatedError(
            'Appium only supports W3C-style capability objects. ' +