-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: iOS: Video Record: make start video record asynchronous #12486
Comments
I think this is the main showstopper: https://github.com/appium/appium-xcuitest-driver/blob/273d9ce89de8c52afba015c40530040688f1f829/lib/commands/recordscreen.js#L76 We need some better feedback from ffmpeg to make sure the video recording has started. I'll check on what can be done |
Can you also attach the full log with timestamps to see what takes the most of the time? |
@amedvedjev I did some improvements in appium/appium-xcuitest-driver#932. Could you please merge it to your local source and check if the performance is better? Detailed logs with timestamps are welcome. Check https://appiumpro.com/editions/47 for more details about deployment from source |
@mykola-mokhnach here is Full log (without your changes yet): https://gist.github.com/amedvedjev/9d16e33458cd5d466dc4e9876e0ac0a0 @mykola-mokhnach here is with your linked branch https://gist.github.com/amedvedjev/87df09a516110dd55e03ecbd347cf3e4 1sec!!! instead of 10sec |
The fix has been published in appium@beta |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The problem
When we start ios test with video recording we have 10 sec (numbers can vary depending on hardware. current number from macMini i7 model 2019 while executing on 4 phones in parallel) delay while video starting. And after it continues test execution.
when we speak about 1 test it does not matter but e.g. with 100 tests it takes 100x10/60 = 17 min which increase our tests execution from 30 -> 45 min.
If it possible pls make it asynchronous.
Environment
Link to Appium logs
Example of logs from macBookPro:
2019-04-12 06:57:09:650 - [HTTP] --> POST /wd/hub/session/a6c21474-95d8-45d0-af4e-d9018db7285b/appium/start_recording_screen
....
2019-04-12 06:57:14:716 - [HTTP] <-- POST /wd/hub/session/a6c21474-95d8-45d0-af4e-d9018db7285b/appium/start_recording_screen 200 5065 ms - 12
Code To Reproduce Issue
((IOSDriver) driver).startRecordingScreen(
new IOSStartScreenRecordingOptions()
.withFps(30));
The text was updated successfully, but these errors were encountered: