-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up iproxy and ffmpeg startup #932
Conversation
this.mainProcess.on('output', (stdout, stderr) => { | ||
if (stderr && !stderr.includes('frame=')) { | ||
ffmpegLogger.info(`${stderr}`); | ||
if (stderr) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use this in a start detector on start
? https://github.com/appium/node-teen_process#start-detectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because if startDetector fails then the whole process is considered invalid. Although, I assume the process might be still running, but it just didn't have enough time for the initialisation.
Please don't merge this PR without the confirmation about perf improvement |
@KazuCocoa Does xcuitest driver perform better if you run video recording using this PR on your machine? |
Yes. I measured three times as below against https://github.com/appium/ruby_lib_core/blob/73ab4718a616c49676eadc88cc3ecf9e39a81e67/test/functional/ios/ios/mjpeg_server_test.rb . The performane has been improved 👍
|
This PR adds more advanced checks for ffmpeg and iproxy startup verification