-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instruments Trace Complete #160
Comments
If appium closes instruments successfully, it will delete the .trace directories by default. If instruments crashes, they won't be deleted. Alternatives are:
|
It'd be nice if they were deleted on startup and when @driver.quit is called. |
They are deleted in every case that appium itself doesn't crash due to an error or we can't get the name of the tracedir for some reason. So when you call @driver.quit, appium shuts down instruments and retrieves the name of the tracedir which instruments created (which we can always get except maybe in some rare instruments crash cases). It then (by default) removes this tracedir. So if you run a clean test, you should see no tracedirs in your appium directory afterward. Is this not your experience? If what you're asking about is "how do we get rid of these even when something goes wrong and we can't know that a tracedir was created", then we'll have to resort to some kind of I'm more inclined to (a) try to figure out why these crashes are happening and exit gracefully instead, perhaps removing tracedirs that we detect in another way and (b) adding a "cleanup" script which gets rid of these along with the instruments socket and any other tempfiles that appium might have created. This could be run with |
Appium frequently crashes and I'm left with tons of |
It could, but for some people those tracedirs contain valuable diagnostic information (or so I have been told). I'm fine blowing them all away if a flag is set, though. Another issue with this particular suggestion is that if Appium itself crashes, we can't do anything at all on @driver.quit, since the server is no longer even listening. We could also do it on server startup, which doesn't guarantee no tracedirs ever, but at least keeps things more clean. Anyway, I'll go ahead and implement something that will delete these dirs more often. |
I guess the real solution is fixing the crash issues then it won't be a problem. A flag would be nice.
|
The flag I'm thinking of already exists, it's |
Sounds good. |
let me know if this doesn't delete things often enough for you. |
Add showXcodeLog cap and functionality
Add showXcodeLog cap and functionality
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Is there some way to stop the
instrumentscli.trace
files from being created? After testing for a bit, there are quite a few .trace files.The text was updated successfully, but these errors were encountered: