Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(base-driver): Use WeakRef to reference the driver instance in the log prefix generator #16636

Merged
merged 3 commits into from Mar 23, 2022
Merged

fix(base-driver): Use WeakRef to reference the driver instance in the log prefix generator #16636

merged 3 commits into from Mar 23, 2022

Conversation

mykola-mokhnach
Copy link
Collaborator

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

jlipps
jlipps approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. also fwiw semantic commits should have a scope for intelligent releasing, e.g. fix(appium): instead of just fix:.

@mykola-mokhnach mykola-mokhnach changed the title fix: Use WeakRef to reference the driver instance in the log prefix generator fix(base-driver): Use WeakRef to reference the driver instance in the log prefix generator Mar 23, 2022
@mykola-mokhnach mykola-mokhnach merged commit bbfc7ef into appium:2.0 Mar 23, 2022
@mykola-mokhnach mykola-mokhnach deleted the num_chr branch March 23, 2022 17:48
@mykola-mokhnach mykola-mokhnach mentioned this pull request Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps approved these changes

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mykola-mokhnach @jlipps @KazuCocoa