fix(base-driver): Update/simplify the logic for logger prefix

[mykola-mokhnach]

Proposed changes

This restores #16636 with some slight changes to make ts linter happy

[boneskull]

Can you explain what this avoids?

[mykola-mokhnach]

This avoid possible memory leak in case the logger object itself is preserved somewhere. Without WeakRef the actual driver instance would be preserved with it as it is captured in the corresponding closure.

[boneskull]

I don't think we need WeakRef here... please see comment.

[mykola-mokhnach]

I have updated the implementation, but now I have no idea about how to update unit tests after _log object gets reassigned in createSession. I also don't have a good idea on how to make prefix mutable on the logger itself

[boneskull]

@mykola-mokhnach Can I push to your branch?

[mykola-mokhnach]

@mykola-mokhnach Can I push to your branch?

sure, not a problem at all

[mykola-mokhnach]

Seems like I got some progress as of now. Please review once more @boneskull

[boneskull]

This is good and was basically what I was suggesting, so thanks.

For a test I think all you really need to do is have something that compares this.log.prefix before and after calling createSession(), and again for deleteSession(). We can assert the prefix looks a certain way, or we can just assert it's not the same.

You'd probably want to put that in the baseDriverUnitTests function of test/basedriver/driver-tests.js