Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/wd/hub/session/:sessionId/rotation implementation #7131

Closed
2 of 4 tasks
SrinivasanTarget opened this issue Oct 31, 2016 · 9 comments
Closed
2 of 4 tasks

/wd/hub/session/:sessionId/rotation implementation #7131

SrinivasanTarget opened this issue Oct 31, 2016 · 9 comments

Comments

@SrinivasanTarget
Copy link
Member

SrinivasanTarget commented Oct 31, 2016

Implement endpoint /wd/hub/session/:sessionId/rotation in below drivers,

  • XCUITest/WDA
  • UIAutomator2
  • Legacy iOS Driver
  • Legacy android Driver

@sravanmedarapu @imurchie FYI

https://github.com/appium/appium-base-driver/blob/master/lib/mjsonwp/routes.js#L178

@triager triager added the Needs Triage bugs which are not yet confirmed label Oct 31, 2016
@TikhomirovSergey
Copy link

TikhomirovSergey commented Oct 31, 2016

Yes. I think we need it for new modes (XCUITest/WDA, UIAutomator2) at least. It would be cool if old automation modes could support it.

@sravanmedarapu
Copy link
Member

Sure @SrinivasanTarget .

From WDA implementation could see end point supports UIDeviceOrientationFaceUp and UIDeviceOrientationFaceDown, seems setting these orientations are not possible in android.

@SrinivasanTarget
Copy link
Member Author

I personally didn't test those on iOS yet. Will test and update soon. Does
rest can be implemented for Android?

On Tue 1 Nov, 2016, 6:23 PM Sravan Medarapu, notifications@github.com
wrote:

Sure @SrinivasanTarget https://github.com/SrinivasanTarget .

From WDA
https://github.com/rafael-chavez/WebDriverAgent/blob/5382290c269edcc1a46d7d59fa90d15dad10d9df/WebDriverAgentLib/Categories/XCUIDevice%2BRotation.m#L37
implementation could see end point supports UIDeviceOrientationFaceUp and
UIDeviceOrientationFaceDown, seems setting these orientations are not
possible in android.


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#7131 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIfAJb89C1Mtw8Vr9hU5xenhpLgIZfyiks5q5zY7gaJpZM4Kk0sX
.

@bootstraponline
Copy link
Member

It looks like Android supports quite a few different orientation modes.

android:screenOrientation=["unspecified" | "behind" |
                                     "landscape" | "portrait" |
                                     "reverseLandscape" | "reversePortrait" |
                                     "sensorLandscape" | "sensorPortrait" |
                                     "userLandscape" | "userPortrait" |
                                     "sensor" | "fullSensor" | "nosensor" |
                                     "user" | "fullUser" | "locked"]

and for getting:.

ROTATION_0
ROTATION_180
ROTATION_270
ROTATION_90

Appium is suppose to follow the mobile spec which is different from just exposing the native rotation primitives.

@sravanmedarapu
Copy link
Member

As Android supporting limited Orientations, possible combinations would be

Portrait : {"x" : 0, "y" : 0, "z" : 0}
PortraitUpsideDown : {"x" : 0, "y" : 0, "z" : 180}
LandscapeLeft : {"x" : 0, "y" : 0, "z" : 270}
LandscapeRight :{"x" : 0, "y" : 0, "z" : 90}

@SrinivasanTarget
Copy link
Member Author

@sravanmedarapu We are getting method not implemented error. Logs here: https://gist.github.com/SrinivasanTarget/6e1e029a4f82e2055531923809282403. Can you check this?

@SrinivasanTarget
Copy link
Member Author

@TikhomirovSergey FYI

@jlipps
Copy link
Member

jlipps commented Apr 17, 2017

Going to close this since we're not really putting energy into supporting the legacy drivers right now.

@jlipps jlipps closed this as completed Apr 17, 2017
@imurchie imurchie removed the Needs Triage bugs which are not yet confirmed label Jul 13, 2017
@lock
Copy link

lock bot commented Apr 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants