Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge desired capabilities in getSession with what WDA returns #7480

Closed
jlipps opened this issue Dec 9, 2016 · 4 comments
Closed

merge desired capabilities in getSession with what WDA returns #7480

jlipps opened this issue Dec 9, 2016 · 4 comments
Assignees
Labels
XCUITest regarding xcuitest driver

Comments

@jlipps
Copy link
Member

jlipps commented Dec 9, 2016

When you call GET /session/:id on an XCUITest session, it proxies the request to WDA, which returns weird things. This breaks some client behavior (see appium/ruby_lib#390).

The solution is for us to merge our desired capabilities into what WDA sends back as a result of the proxy request, and give that to the client instead.

@jlipps jlipps added the XCUITest regarding xcuitest driver label Dec 9, 2016
@jlipps jlipps added this to the Optimus Prime [Sprint 3] milestone Dec 9, 2016
@jlipps jlipps self-assigned this Dec 9, 2016
@triager triager added the Needs Triage bugs which are not yet confirmed label Dec 9, 2016
jlipps added a commit to appium/appium-xcuitest-driver that referenced this issue Dec 9, 2016
jlipps added a commit to appium/appium-xcuitest-driver that referenced this issue Dec 9, 2016
@jlipps jlipps removed the Needs Triage bugs which are not yet confirmed label Dec 9, 2016
@danqa
Copy link

danqa commented Dec 9, 2016

@jlipps Thanks for fixing! How can I get this fix? Do I need to wait for the next Appium release? And I assume Sauce would have to install it on their end as well.

@jlipps
Copy link
Member Author

jlipps commented Dec 9, 2016

@danqa since you're only experiencing the bug on Sauce, unfortunately you'll need to wait till (a) 1.6.3 is released, and (b) 1.6.3 is made available on sauce (usually within a day or two of the open source release)

@danqa
Copy link

danqa commented Dec 9, 2016

Kinda what I thought you would say. Thanks again for the fix.

@lock
Copy link

lock bot commented Apr 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Apr 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
XCUITest regarding xcuitest driver
Projects
None yet
Development

No branches or pull requests

3 participants