Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel for generating docs #11481

Merged
merged 2 commits into from Oct 5, 2018
Merged

Update babel for generating docs #11481

merged 2 commits into from Oct 5, 2018

Conversation

imurchie
Copy link
Contributor

@imurchie imurchie commented Oct 4, 2018

Proposed changes

We use babel-node to generate docs from yaml. Update this infrastructure.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@imurchie
Copy link
Contributor Author

imurchie commented Oct 4, 2018

Update: we do all the transpilation anyway. So just add the docs generation scripts to the transpilation sources, and adjust the paths so the scripts work in ./build.

Then the package only needs to import @babel/runtime like any other Appium package.

@imurchie imurchie merged commit 91204eb into master Oct 5, 2018
@imurchie imurchie deleted the isaac-generate-docs branch October 5, 2018 12:22
imurchie added a commit that referenced this pull request Oct 25, 2018
* Update babel for generating docs

* Get rid of custom babel stuff, in favour of normal building
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants