only allow cors when using a special flag #11719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgraham
approved these changes
Nov 21, 2018
|
good idea, @dpgraham. added. |
dpgraham
approved these changes
Nov 22, 2018
dpgraham
pushed a commit
that referenced
this pull request
Nov 22, 2018
* only allow cors when using a special flag * add docs about --allow-cors flag
|
i guess we should note this in the changelog as a breaking change |
|
Added it to changelog |
zcmgyu
added a commit
to zcmgyu/selenium
that referenced
this pull request
Sep 6, 2019
Use case: When make a request to Selenium server though API in JS code in browser, the request will be ignored by CORS policy. So, I added —allow-cors flag to turn CORS compatibility mode on, which will allow connections to the Selenium server from within websites hosted on any domain I'm inspired by @jlipps. He made the same thing in Appium server. appium/appium#11719
1 task
shs96c
pushed a commit
to SeleniumHQ/selenium
that referenced
this pull request
Sep 10, 2019
Use case: When make a request to Selenium server though API in JS code in browser, the request will be ignored by CORS policy. So, I added —allow-cors flag to turn CORS compatibility mode on, which will allow connections to the Selenium server from within websites hosted on any domain I'm inspired by @jlipps. He made the same thing in Appium server. appium/appium#11719
jimevans
pushed a commit
to jimevans/selenium
that referenced
this pull request
Sep 13, 2019
Use case: When make a request to Selenium server though API in JS code in browser, the request will be ignored by CORS policy. So, I added —allow-cors flag to turn CORS compatibility mode on, which will allow connections to the Selenium server from within websites hosted on any domain I'm inspired by @jlipps. He made the same thing in Appium server. appium/appium#11719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on appium/appium-base-driver#285