Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version checks #11996

Merged
merged 1 commit into from Jan 15, 2019
Merged

Update node version checks #11996

merged 1 commit into from Jan 15, 2019

Conversation

imurchie
Copy link
Contributor

Proposed changes

In package.json we require Node 8+ but in our checks during startup we only require 6+. This PR fixes that disparity, but also gets rid of the manual handling of versions with regular expressions, moving to semver (which we already have as a production dependency), and uses the value in package.json instead of hardcoding it into the code.

Also, currently there is no Node deprecation, so comment out that code and add note to update when it is needed.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@imurchie imurchie merged commit 97fbb19 into master Jan 15, 2019
@imurchie imurchie deleted the isaac-node-version branch January 15, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant