add setting --tmp arg as process.env.APPIUM_TMP_DIR #12585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2019
imurchie
reviewed
May 3, 2019
|
Yes, https://github.com/appium/appium/blob/master/lib/config.js#L217-L224 creates the path before the |
|
|
jlipps
approved these changes
May 3, 2019
lib/appium.js
Outdated
| @@ -158,6 +158,13 @@ const pendingDriversGuard = new AsyncLock(); | |||
|
|
|||
| class AppiumDriver extends BaseDriver { | |||
| constructor (args) { | |||
| // It is necessary to set `--tmp` here since it should set to | |||
lib/appium.js
Outdated
| @@ -158,6 +158,13 @@ const pendingDriversGuard = new AsyncLock(); | |||
|
|
|||
| class AppiumDriver extends BaseDriver { | |||
| constructor (args) { | |||
| // It is necessary to set `--tmp` here since it should set to | |||
| // process.env.APPIUM_TMP_DIR once at initial time in Appium lifecycle. | |||
There was a problem hiding this comment.
at an initial point in the Appium lifecycle
lib/appium.js
Outdated
| @@ -158,6 +158,13 @@ const pendingDriversGuard = new AsyncLock(); | |||
|
|
|||
| class AppiumDriver extends BaseDriver { | |||
| constructor (args) { | |||
| // It is necessary to set `--tmp` here since it should set to | |||
| // process.env.APPIUM_TMP_DIR once at initial time in Appium lifecycle. | |||
| // The process argument will be referred by BaseDriver. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
related to appium/appium-support#112 and #12527
process.env.APPIUM_TMP_DIRshould be set once in Appium process.In BaseDriver,
this.opts.tmpDirrefersprocess.env.APPIUM_TMP_DIR, and the assignment should happen before callingsuperhere.https://github.com/appium/appium-base-driver/blob/d214a0d1f2aa3aecd8fd4033460ce37176ca4c87/lib/basedriver/driver.js#L49
After this and appium/appium-support#112,
--tmpflag will be respected in all of Appium modules which calltempDirmodule.I've tested below patterns in ruby_lib_core test suite adding logs in
tempDirmodule:The ruby_lib_core include screen recording, pull/push apks like appium/appium-android-driver#538
Then, I ensured Appium log had no
/var/folders/xxxx. They called--tmparg.Types of changes
What types of changes does your code introduce to Appium?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...