Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the obsolete --enable-heapdump command line arg #12609

Merged
merged 1 commit into from
May 9, 2019
Merged

Remove the obsolete --enable-heapdump command line arg #12609

merged 1 commit into from
May 9, 2019

Conversation

mykola-mokhnach
Copy link
Collaborator

Proposed changes

Node12 introduced the built-in heap dumping feature, so it is time to get rid of the custom heapdump module usage (especially taking into account it's native and does not always compile properly for newer Node releases)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.211% when pulling a25f2f1 on mykola-mokhnach:rm_heapdump into 3d7a011 on appium:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants