Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chromedriver documentation #13044

Merged
merged 4 commits into from Aug 8, 2019
Merged

Update chromedriver documentation #13044

merged 4 commits into from Aug 8, 2019

Conversation

mykola-mokhnach
Copy link
Collaborator

Proposed changes

Added the description of latest chromedriver versions, the link to the official Version Selection page and the description of chromedriver_autodownload feature.

@coveralls
Copy link

coveralls commented Aug 7, 2019

Coverage Status

Coverage remained the same at 89.893% when pulling fddd8b4 on mykola-mokhnach:cd_doc into eb2ed16 on appium:master.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to add a link, otherwise lgtm 👍

@@ -118,7 +122,9 @@ in it. The contents of the file need to be parsable as a JSON object, like:
}
```

### Installing an network issues
Since Appium 1.15.0 there is a possibility to automatically download the necessary chromedriver(s) into `chromedriverExecutableDir` from the official Google storage. The script will automatically search for the newest chromedriver version that supports the given browser/web view, download it (the hash sum is verified as well for the downloaded archive) and add to the `chromedriverChromeMappingFile` mapping. Everything, which is needed to be done from your side is to execute the server with `chromedriver_autodownload` feature enabled (like `appium --allow-insecure chromedriver_autodownload`).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about appending the link to https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/security.md for more details about the security flag?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the link

@mykola-mokhnach mykola-mokhnach merged commit 805ecae into appium:master Aug 8, 2019
@mykola-mokhnach mykola-mokhnach deleted the cd_doc branch October 6, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants