Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Appium 1.16.0 #13634

Closed
wants to merge 15 commits into from
Closed

[WIP] Appium 1.16.0 #13634

wants to merge 15 commits into from

Conversation

dpgraham
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@dpgraham dpgraham changed the title Appium 1.16.0 [WIP] Appium 1.16.0 Nov 25, 2019
jlipps
jlipps reviewed Nov 25, 2019
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the one thing i remember doing was adding the custom events logging (still working on docs)

@imurchie
Copy link
Contributor

Is it just me or is the shrinkwrap file empty?

@imurchie
Copy link
Contributor

Can we make sure that appium-remote-debugger version 7.1.0 is in?

@dpgraham
Copy link
Contributor Author

I just pushed the shrinkwrap. Remote debugger is 7 as a sub-dependency of xcuitest-driver, but is 4 as a sub-dependency of fake-driver and 5 as a sub-dependency of flutter-driver.

KazuCocoa
KazuCocoa reviewed Nov 26, 2019
View reviewed changes
npm-shrinkwrap.json
"requires": {
"@wdio/logger": "5.16.5",
"deepmerge": "^4.0.0",
"glob"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update here to 2.3.3 or can we ignore here since appium-xcuitest-driver has the 2.3.3 as a dependency in this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm, this comment was against below in line 2884...

    "appium-webdriveragent": {
      "version": "1.3.5",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... flutter driver 0.0.20 depends on lower xcuitest driver (and base driver' too).

@truongsinh Could you publish a new version which has current your repository's master package.json?

@imurchie
Copy link
Contributor

iOS using XCUITest

* Allow execution of WDA without app under test (https://github.com/appium/appium-xcuitest-driver/pull/1093)
* Add `mobile: deleteFile` command for removing files/folders from the device (https://github.com/appium/appium-xcuitest-driver/pull/1095)
* Fall back to `ios-deploy` if native install fails (https://github.com/appium/appium-xcuitest-driver/pull/1098)
* Make sure ports are properly closed when cleaning up (https://github.com/appium/appium-xcuitest-driver/pull/1094)
* Handle socket errors on session start (https://github.com/appium/appium-xcuitest-driver/pull/1101)
* Properly handle creating simulators with patch versions (https://github.com/appium/node-simctl/pull/89)
* Fix handling of Safari console log (https://github.com/appium/appium-remote-debugger/pull/176)
* Add ability to interact with Shadow DOM in Safari (https://github.com/appium/appium-remote-debugger/commit/559395a16088142b27289dbac6d3a5ab36caa716)
* New capabilities
  * `safariLogAllCommunication` - log all plists passed to and received from the Web Inspector (https://github.com/appium/appium-xcuitest-driver/pull/1105)
  * `safariLogAllCommunicationHexDump` - log the raw data passed to and received from the Web Inspector (https://github.com/appium/appium-xcuitest-driver/pull/1105)
  * `safariSocketChunkSize` - change the size of the data passed to the Web Inspector on real devices (https://github.com/appium/appium-xcuitest-driver/pull/1105)
  * `appPushTimeout` - timeout for application upload in millisecond, on real devices (https://github.com/appium/appium-xcuitest-driver/pull/1104)

@coveralls
Copy link

coveralls commented Nov 28, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 89.035% when pulling 9d2a5a4 on 1.16 into 68da5da on master.

KazuCocoa
KazuCocoa reviewed Dec 7, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
imurchie
imurchie reviewed Dec 11, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
mykola-mokhnach
mykola-mokhnach reviewed Dec 11, 2019
View reviewed changes
package.json Outdated
@@ -11,7 +11,7 @@
"firefoxos",
"testing"
],
"version": "1.16.0-beta.3",
"version": "1.16.0-rc.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach the next will be to hack off the -rc.1 suffix and then tag + publish 1.16.0.

mykola-mokhnach
mykola-mokhnach reviewed Dec 11, 2019
View reviewed changes
CHANGELOG.md
* Make sure ports are properly closed when cleaning up (https://github.com/appium/appium-xcuitest-driver/pull/1094)
* Handle socket errors on session start (https://github.com/appium/appium-xcuitest-driver/pull/1101)
* Properly handle creating simulators with patch versions (https://github.com/appium/node-simctl/pull/89)
* Fix handling of Safari console log (https://github.com/appium/appium-remote-debugger/pull/176)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say one of the most significant changes in this release are the improvements in the safari remote debugger

imurchie
imurchie reviewed Dec 11, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
imurchie
imurchie reviewed Dec 11, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
imurchie
imurchie reviewed Dec 11, 2019
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
KazuCocoa
KazuCocoa reviewed Dec 12, 2019
View reviewed changes
npm-shrinkwrap.json
"requires": {
"@wdio/logger": "5.16.10",
"deepmerge": "^4.0.0",
"glob
Copy link
Member

@KazuCocoa KazuCocoa Dec 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sees need 3.10.1 (appium-xcuitest-driver)
(Capabilities after 3.8.0 is also addressed in changelog)

npm-shrinkwrap.json Outdated
"requires": {
"@wdio/logger": "5.16.10",
"deepmerge": "^4.0.0",
"glob
Copy link
Member

@KazuCocoa KazuCocoa Dec 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.3.1? (appium-remote-debugger)

@imurchie
Copy link
Contributor

Dependencies have been updated.

KazuCocoa
KazuCocoa reviewed Dec 22, 2019
View reviewed changes
npm-shrinkwrap.json
"requires": {
"@wdio/logger": "5.16.10",
"deepmerge": "^4.0.0",
"glob
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to 2.16.1 to get bug fixes? (io.appium.settings)

@dpgraham
Copy link
Contributor Author

Published. Changelog was pushed directly to master.

@dpgraham dpgraham closed this Dec 23, 2019
@dpgraham
Copy link
Contributor Author

^ do not delete the branch!

@KazuCocoa KazuCocoa mentioned this pull request Dec 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps left review comments

@imurchie imurchie imurchie left review comments

@KazuCocoa KazuCocoa KazuCocoa left review comments

@mykola-mokhnach mykola-mokhnach mykola-mokhnach left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dpgraham @imurchie @coveralls @jlipps @KazuCocoa @mykola-mokhnach @triager @blane1988