Fix 186 #187

bootstraponline · 2013-02-14T15:46:09Z

Fixed version of #186.

$ git remote add upstream git@github.com:appium/appium.git
$ git fetch upstream
$ git checkout -b fix
$ git cherry-pick cfbded8
$ open -a Xcode app/ios.js 
$ git add .
$ git commit
$ git cherry-pick 689ae95
$ git cherry-pick c5652f5
$ git cherry-pick e6a9c50
$ git rebase -i HEAD~2

pick 5fa17ab Add support for setValueImmediate
f 54144df Fix semicolon

…aks coming from the unix domain sockets.

This new mobile: command restores the ability to manually set the value of all objects, including UITextField using the direct setValue() JS in UIAutomation. By default, POST /value will generate keypress events in a UITextView, as is in line with the webdriver specification. With this additon, you can now use the 'old' appium method of setting directly with setValue by using: mobile:setvalue [{ element: elementID, value: value }]

jlipps · 2013-02-14T16:23:54Z

@gaige I love this! Thanks for doing the research on the socket issue and the mobile: setValue looks great too. And thanks for the git help @bootstraponline. @gaige, can you do a quick code cleanup for me so I can merge:

spaces surrounding "=" and other operators e.g. in assignments
no spaces before first parameter of a function call

(or maybe it's more straightforward for @bootstraponline to do this since it's his PR--if he doesn't have time soon, I'll merge and we can do style fixes later).

bootstraponline · 2013-02-14T17:00:28Z

@jlipps Would you mind creating a style guide page on the wiki? I'm happy to use whatever style. It'd be helpful if the style was documented.

bootstraponline · 2013-02-14T17:06:05Z

I think I fixed everything. Please leave inline comments for whatever lines I missed.

bootstraponline · 2013-02-14T17:17:43Z

instruments/instruments.js

+        if (self.currentSocket) {
+			self.debug("Socket closed forcibly due to exit");
+			self.currentSocket.end();
+//			self.currentSocket=null;


Should this be uncommented or removed?

@gaige, any thoughts about that comment? also, indentation seems weird.

Sorry, was offline at a meeting. The commented line should be removed.

jlipps · 2013-02-14T17:27:00Z

style guide added https://github.com/appium/appium/wiki/Style-guide-for-contributors

bootstraponline · 2013-02-14T17:32:56Z

style guide added

Thanks.

jlipps · 2013-02-14T17:32:57Z

app/controller.js

+exports.setValueImmediate = function(req, res) {
+  var element = req.body.element
+    , value = req.body.value;
+	if (checkMissingParams(res, {element:element,value:value})) {


space after comma

jlipps · 2013-02-14T17:34:55Z

line-commented on specific issues remaining

bootstraponline · 2013-02-14T17:42:34Z

I think !== should be added to the style guide. I fixed the remaining issues other than the commented self.currentSocket=null;

bootstraponline · 2013-02-14T17:46:11Z

instruments/instruments.js

+        if (self.currentSocket) {
+			    self.debug("Socket closed forcibly due to exit");
+			    self.currentSocket.end();
+//			  self.currentSocket=null;


It looks like the old discussion went away. @gaige Is this commented out for a reason?

i'm fine leaving it commented for now, let's just fix the style and make the comment at the same level as the code, so:

self.currentSocket.end() // self.currentSocket = null;

jlipps · 2013-02-14T17:57:24Z

I think !== should be added to the style guide.

added, thanks.

bootstraponline · 2013-02-14T18:04:14Z

I think it's ready to merge.

jlipps · 2013-02-14T18:05:32Z

instruments/instruments.js

+			    self.debug("Socket closed forcibly due to exit");
+			    self.currentSocket.end();
+          // self.currentSocket = null; // TODO: Why is this commented?
+			self.currentSocket.destroy();	// close this


these two lines look like they need to be indented 4 spaces

jlipps · 2013-02-14T18:05:45Z

added one more note

bootstraponline · 2013-02-14T18:13:15Z

I miss gofmt. I fixed the latest issue.

Fix 186

copyfromwindowsnetwrokshare

* Make the build more stable * Adjust language handling * Adjust language handling

copyfromwindowsnetwrokshare

* Make the build more stable * Adjust language handling * Adjust language handling

* Add urls caching logic * Tune date verification * Fix dictionary access * tune try/catch scope * simplify the condition

Gaige B Paulsen and others added 3 commits February 14, 2013 10:41

Change /value to send keys as per spec when used with text fields

7d0e2c2

Object leak removal, and some work at removing the file descriptor le…

8ce29bb

…aks coming from the unix domain sockets.

bootstraponline mentioned this pull request Feb 14, 2013

Resolve #152 and partially #148 #186

Closed

bootstraponline reviewed Feb 14, 2013
View reviewed changes

jlipps reviewed Feb 14, 2013
View reviewed changes

bootstraponline reviewed Feb 14, 2013
View reviewed changes

jlipps reviewed Feb 14, 2013
View reviewed changes

Fix style

0412eae

jlipps added a commit that referenced this pull request Feb 14, 2013

Merge pull request #187 from bootstraponline/fix_186

ab18a9c

Fix 186

jlipps merged commit ab18a9c into appium:master Feb 14, 2013

jlipps mentioned this pull request Feb 14, 2013

Running entire suite of 'grunt functional' results in 'EMFILE, too many open files' error #148

Closed

gaige mentioned this pull request Feb 14, 2013

setValue for textFields doesn't generate full event stream #152

Closed

bootstraponline mentioned this pull request Mar 11, 2013

(null) could not be tapped #254

Closed

sebv pushed a commit to sebv/appium that referenced this pull request May 11, 2014

ci ios branch for build appium#187.2

8a7fa07

dpgraham pushed a commit to dpgraham/appium that referenced this pull request Oct 1, 2018

Merge pull request appium#187 from yaphatak/copyfromwindowsshare

d2d18e1

copyfromwindowsnetwrokshare

dpgraham pushed a commit to dpgraham/appium that referenced this pull request Oct 1, 2018

Stabilize the build (appium#187)

f19a304

* Make the build more stable * Adjust language handling * Adjust language handling

dpgraham pushed a commit to dpgraham/appium that referenced this pull request Nov 7, 2018

Merge pull request appium#187 from yaphatak/copyfromwindowsshare

f94d3e0

copyfromwindowsnetwrokshare

dpgraham pushed a commit to dpgraham/appium that referenced this pull request Nov 7, 2018

Stabilize the build (appium#187)

67f0599

* Make the build more stable * Adjust language handling * Adjust language handling

boneskull pushed a commit to boneskull/appium that referenced this pull request May 17, 2021

Add urls caching logic (appium#187)

d47d597

* Add urls caching logic * Tune date verification * Fix dictionary access * tune try/catch scope * simplify the condition

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 186 #187

Fix 186 #187

bootstraponline commented Feb 14, 2013

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

bootstraponline Feb 14, 2013

jlipps Feb 14, 2013

gaige Feb 14, 2013

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

jlipps Feb 14, 2013

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

bootstraponline Feb 14, 2013

jlipps Feb 14, 2013

bootstraponline Feb 14, 2013

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

jlipps Feb 14, 2013

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

Fix 186 #187

Fix 186 #187

Conversation

bootstraponline commented Feb 14, 2013

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

Choose a reason for hiding this comment

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013

Choose a reason for hiding this comment

jlipps commented Feb 14, 2013

bootstraponline commented Feb 14, 2013