Fix #148 leaving domain sockets open #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make sure the domain socket closes, we need to close() the socket server itself, which requires paying attention to its creation and
|
looks great; can you add or something similar in the constructor? it's sort of a semi-convention i've been using for semi-OO-ness |
|
Yep... |
In order to make sure the domain socket closes, we need to close() the socket server itself, which requires paying attention to its creation and
jlipps
added a commit
that referenced
this pull request
Feb 14, 2013
Fix #148 leaving domain sockets open
dpgraham
pushed a commit
to dpgraham/appium
that referenced
this pull request
Oct 1, 2018
dpgraham
pushed a commit
to dpgraham/appium
that referenced
this pull request
Nov 7, 2018
boneskull
pushed a commit
to boneskull/appium
that referenced
this pull request
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make sure the domain socket closes, we need to close() the
socket server itself, which requires paying attention to its creation
and subsequently closing the listener when Instruments quits from under us.