Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appium): prepare setup subcommand as shortcut for drivers/plugins installation #20102
feat(appium): prepare setup subcommand as shortcut for drivers/plugins installation #20102
Changes from 5 commits
ffa447a
006742b
c56375c
af2502e
9d32e41
1ed6f84
8f5223e
f041b2c
68f7baf
88cca05
08e3c6d
be9d10d
c29004b
a0b8701
4fc664c
b9207cc
ae17a20
942b1f8
f9a2a0c
ca82886
4435a5b
869655b
e426f09
3f404ed
05def96
56bc740
1ae4e3f
8981f79
56119c5
4c1b00a
c32bff9
bf41896
6f2bf92
59d59da
b9e89cd
afe4e90
3b32255
e7733dd
a01675e
92b5d4e
985ccf5
063c757
d1126ba
91def85
e4d6d49
237217a
ab7b153
76a5d89
941e703
a3a9e6c
2223b33
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does
if no APPIUM_HOME was empty
mean? Do you mean to sayunless APPIUM_HOME isn't empty
, ofif APPIUM_HOME is empty
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, that was my bad. Right now is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the return value should be the merge of the return values of all the install commands, in case this is run by script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaning by
appium setup
? The current behavior is if the command succeeds, the existing status will be0
. Otherwise non-zero, so probably users can catch the error if an error occurred.current e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i meant, in
--json
mode it can return a nice json object which is the merge of all the install operations.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> #20130 I'll check and update the
--json
mode