Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(base-driver): Update the web socket upgrade behavior #20142

Merged
merged 8 commits into from
May 24, 2024
Merged

fix(base-driver): Update the web socket upgrade behavior #20142

merged 8 commits into from
May 24, 2024

Conversation

mykola-mokhnach
Copy link
Collaborator

Proposed changes

This is supposed to solve issues with HTTP/2 requests being unexpectedly rejected. See SeleniumHQ/selenium#13913 and expressjs/express#5678 for more details

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@github-actions github-actions bot added @appium/base-driver Bug a problem that needs fixing labels May 24, 2024
@github-actions github-actions bot added the chore refactoring, overhead, tests, etc. label May 24, 2024
@mykola-mokhnach mykola-mokhnach marked this pull request as ready for review May 24, 2024 12:03
@mykola-mokhnach mykola-mokhnach mentioned this pull request May 24, 2024
Closed
KazuCocoa
KazuCocoa approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mykola-mokhnach mykola-mokhnach merged commit 275790e into appium:master May 24, 2024
9 checks passed
@mykola-mokhnach mykola-mokhnach deleted the http branch May 24, 2024 17:57
@mykola-mokhnach mykola-mokhnach mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlipps jlipps jlipps approved these changes

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@eglitise eglitise Awaiting requested review from eglitise

Assignees
No one assigned
Labels
@appium/base-driver Bug a problem that needs fixing chore refactoring, overhead, tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mykola-mokhnach @jlipps @KazuCocoa