Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger): Print an empty message if no arguments are provided #20284

Merged
merged 1 commit into from
Jun 22, 2024
Merged

fix(logger): Print an empty message if no arguments are provided #20284

merged 1 commit into from
Jun 22, 2024

Conversation

mykola-mokhnach
Copy link
Collaborator

Proposed changes

Currently for calls like log.debug() it prints undefined

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@github-actions github-actions bot added @appium/logger Bug a problem that needs fixing labels Jun 22, 2024
@mykola-mokhnach mykola-mokhnach merged commit 87fc50c into appium:master Jun 22, 2024
9 checks passed
@mykola-mokhnach mykola-mokhnach deleted the log_undef branch June 22, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eglitise eglitise eglitise approved these changes

@KazuCocoa KazuCocoa Awaiting requested review from KazuCocoa

Assignees
No one assigned
Labels
@appium/logger Bug a problem that needs fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mykola-mokhnach @eglitise