Renamed keyevent to press_keycode and added long_press_keycode. #2673
Conversation
|
Looks good to me. I think we'll want appium 1.1 to ship before merging breaking changes. |
|
Sure. This can wait of course. |
| @@ -94,7 +94,8 @@ module.exports = function (appium) { | |||
| // appium-specific extensions to JSONWP | |||
| rest.post('/wd/hub/session/:sessionId?/appium/device/shake', controller.mobileShake); | |||
| rest.post('/wd/hub/session/:sessionId?/appium/device/lock', controller.lock); | |||
| rest.post('/wd/hub/session/:sessionId?/appium/device/keyevent', controller.keyevent); | |||
There was a problem hiding this comment.
is there a reason we can't keep this around and just alias it to pressKeyCode for now? that way existing code doesn't break.
There was a problem hiding this comment.
Originally this was implemented via adb shell input keyevent and that's why it was named keyevent. @paymand had pointed out on Slack that this name isn't great and press_keycode / long_press_keycode are more accurate now that uiautomator is used.
I think it's fine to keep an alias for now, it'd be nice to remove it after a depreciation period though.
There was a problem hiding this comment.
agreed. keeping the alias just means we don't have to change all the clients immediately, so I can merge this asap.
|
Squash to one commit please. |
|
Done. |
Renamed keyevent to press_keycode and added long_press_keycode.
|
thanks! |
Finishing off what was started in #1155.
Changes to Python bindings: appium/python-client#21