Add default packages to uiautomator id search

[bootstraponline]

Given an element with resource id: com.example.android.testing.espresso.BasicSample:id/textToBeChanged

Now we can find this element using only id('textToBeChanged')
In addition to checking the default package name, the android package is also searched:

android:id/textToBeChanged

Fix #4416

I'm working on DroidDriver and the need to fully qualify the ids was getting annoying.

[bootstraponline]

$ mocha -t 60000 -R spec /appium/test/functional/android/apidemos/find/basics-specs.js


  apidemo - find - basics
    ✓ should find a single element by resource-id with implicit package (1371ms)
    ✓ should find multiple elements by resource-id with implicit package (314ms)
    ✓ should find multiple elements by resource-id  with implicit package even when theres just one (72ms)


  3 passing (21s)

[jlipps]

👍 though maybe let's hold off on merging since we're about to publish 1.3.5

[appium-ci]

Can one of the admins verify this patch?

[bootstraponline]

Can one of the admins verify this patch?

what does this even mean? who is an admin on github? we have owners and collaborators

[jlipps]

I think this is a cloudbees thing @sebv is working on. Seems like when one of us replies to this, then additional builds are run?

[jlipps]

added to 1.3.6 (cc @0x1mason)

[sebv]

retest this please

[0x1mason]

retest this please

[0x1mason]

@sebv NullRef during CI. Filed a ticket.

[0x1mason]

Retest this please

[0x1mason]

@sebv I don't want to merge this until we get the null ref sorted. Any ideas on what might be the issue?

[jlipps]

not sure why that build had an NPE. i checked out your branch and ran the tests, it looks good.