Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't proxy chromedriver requests for /wd/hub/:session_id/appium/* #5153

Merged
merged 1 commit into from May 26, 2015

Conversation

whoward
Copy link

@whoward whoward commented May 22, 2015

At my company we're testing an applinks feature (launching the app from links in the browser) and I needed the ability to install/remove apps while running a browser session on Android - I was sad to find out they 404'd

This is my first PR to appium, I'm happy to change things as needed just please help me bring it up to standards. I wanted to write a test to cover it but sadly my experience with Mocha is pretty limited (I'm normally a ruby developer) and I couldn't find existing tests for ChromeAndroid I could hopefully learn from.

@whoward whoward changed the title don't proxy chromedriver requests for /wd/hub/:session_id/appium/* don't proxy chromedriver requests for /wd/hub/:session_id/appium/* May 22, 2015
@whoward
Copy link
Author

whoward commented May 22, 2015

I also saw this section of code which seems to be very similar - I thought it might be an inheritance issue but I couldn't see a way to fix it:

https://github.com/appium/appium/blob/master/lib/devices/android/android.js#L67-L73

jlipps added a commit that referenced this pull request May 26, 2015
don't proxy chromedriver requests for /wd/hub/:session_id/appium/*
@jlipps jlipps merged commit d143fd3 into appium:master May 26, 2015
@jlipps
Copy link
Member

jlipps commented May 26, 2015

yes, you're right there's an inheritance issue here. we're working on fixing the overall architecture so this piece should look nicer in the future.

@jlipps
Copy link
Member

jlipps commented May 26, 2015

and thanks for the contrib!

@whoward
Copy link
Author

whoward commented May 26, 2015

you're welcome - i hope you wont mind a few more down the road :) we're getting to be pretty invested in the appium internals.

@whoward whoward deleted the chromedriver-dont-proxy-appium branch May 26, 2015 17:39
@jlipps
Copy link
Member

jlipps commented May 26, 2015

@whoward you may want to follow the work that's being done in many of the subprojects. we're in the midst of a massive rearchitecture. appium internals are going to look very, very different in a month or two. here's where most of the work is currently taking place:

appium/appium (1.5 branch)
appium/appium-express
appium/node-mobile-json-wire-protocol
appium/appium-base-driver
appium/appium-fake-driver

@whoward
Copy link
Author

whoward commented May 26, 2015

I'll definitely have a look - thanks!

The next thing i'm most interested in putting in is installApp, removeApp and isInstalled for the iOS Simulator (should be possible with xcrun simctl, at least in Xcode 6.3 it appears to be).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants