Support the sessionOverride flag #6445
Conversation
|
👍 |
|
LGTM. would love to see at least a unit test though |
|
Hi, I just tested this commit, to check whether session is really killed. With running
The only way out is to kill server and start again |
|
Ok. I'll look into catching the error. |
|
Added a test, and catch any error coming from the deleting of a session. @norekinc Do you mind trying again? Thanks! |
|
Looks great now 👍 |
| @@ -71,6 +71,41 @@ describe('AppiumDriver', () => { | |||
| await appium.createSession(BASE_CAPS); | |||
| mockFakeDriver.verify(); | |||
| }); | |||
| it.only('should kill all other sessions if sessionOverride is on', async () => { | |||
|
👍 (except for |
Proposed changes
We still have the
--session-overrideserver argument, but it does nothing. Until we support multiple sessions, this should kill any existing sessions.See #6442
Types of changes
What types of changes does your code introduce to Appium?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Reviewers: @scottdixon, @jlipps