Update parser and logging to handle log spy #6671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t actually have values
|
weird, my editor must not have caught these. will fix. |
| @@ -6,7 +6,7 @@ import logger from './logger'; // logger needs to remain first of imports | |||
| import _ from 'lodash'; | |||
| import { server as baseServer } from 'appium-base-driver'; | |||
| import { asyncify } from 'asyncbox'; | |||
| import getParser from './parser'; | |||
| import getParser, { getDefaultArgs } from './parser'; | |||
There was a problem hiding this comment.
This works?
I've always used import { default as getParser, getDefaultArgs } from './parser';
|
@imurchie you're right that was it. it did work, however jshint blows up on it so i changed it. and welp. somehow i broke my feature. fixing. |
… on logs this is necessary for the new appium desktop
…t was undefined in places
|
@imurchie ok everything passes locally and hopefully will on CI this time |
|
\o/ looks like Travis passed, looking for a merge whenever you're happy @imurchie |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new appium desktop will import Appium and run it in memory, so we need a way to attach a log spy method.
Some other cleanup as well along the way.
This is the branch that is currently supporting the work in progress at https://github.com/jlipps/appium-desktop (using
npm link)