Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing TouchActions are a pain in the context of MultiTouchActions #32

Closed
sebv opened this issue Jun 6, 2014 · 5 comments
Closed

Comments

@sebv
Copy link
Member

sebv commented Jun 6, 2014

@Astro03 , reusing Selenium TouchActions is more hindrance than help, in particular, some actions takes double parameters rather than int. Rather than scratching my head for hours, I am going to cut this dependency and write a custom TouchAction class. Have to think of a good name so that it is not confusing.

@Astro03
Copy link
Contributor

Astro03 commented Jun 6, 2014

@sebv - awesome man. i saw the changes. looks similar to the other branches now. :) I like everything except for the project name change to lib. When importing this lib into a solution, it'll just say "lib" instead of what it actually is. Do you care if i change that?

@sebv
Copy link
Member Author

sebv commented Jun 6, 2014

Yeah I noticed it wasn't a good idea when publishing, moved it back, still learning this dotnet thing.

@ytonthat
Copy link

ytonthat commented Jun 6, 2014

I had to set PowerShell's execution policy to unrestricted to get version 1.0.0 through the NuGet Package Manager. Can you publish a signed package so that next time we don't have to use the unrestricted policy? Thanks!

@Astro03
Copy link
Contributor

Astro03 commented Jun 6, 2014

@ytonthat - if i make appium-dotnet-driver be signed, then i believe you have to get the signed selenium webdriver, right? As far as I can tell, the signed web driver is NOT in NuGet, so you'll have to manually download and use them in your solution.

Want me to still make 2 different assemblies available?

@Astro03
Copy link
Contributor

Astro03 commented Jun 6, 2014

@ytonthat @sebv - I have it working for signed, but I would rather wait until we get a signed version for Selenium.Webdriver on NuGet. Without that, things won't work. There is a work around where you would download the signed Selenium.Webdriver from the download page instead of NuGet and this would work but that would defeat the purpose of putting our assembly on NuGet.

I've sent a message to the Selenium guys so hopefully they will put the signed version on NuGet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants