New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of MissingParameterException #102

Closed
0x1mason opened this Issue Sep 8, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@0x1mason
Contributor

0x1mason commented Sep 8, 2014

java-client checks on the client side for missing parameters in MultiTouchAction::perform and throws a custom exception. However, there aren't other checks for valid params. We should check parameters consistently in the client or not at all.

Also, we should probably use Preconditions.checkArgument(foo, msg);, since this is part of the Guava idiom, and add throws IllegalArgumentException to function signatures that assert precondtions.

@bootstraponline

This comment has been minimized.

Show comment
Hide comment
@bootstraponline
Member

bootstraponline commented Sep 8, 2014

@TikhomirovSergey TikhomirovSergey referenced this issue Nov 23, 2017

Merged

#102 FIX #772

1 of 4 tasks complete

TikhomirovSergey added a commit that referenced this issue Nov 25, 2017

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey
Member

TikhomirovSergey commented Nov 25, 2017

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment