Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of MissingParameterException #102

Closed
0x1mason opened this issue Sep 8, 2014 · 2 comments
Closed

Inconsistent use of MissingParameterException #102

0x1mason opened this issue Sep 8, 2014 · 2 comments
Labels

Comments

@0x1mason
Copy link
Contributor

0x1mason commented Sep 8, 2014

java-client checks on the client side for missing parameters in MultiTouchAction::perform and throws a custom exception. However, there aren't other checks for valid params. We should check parameters consistently in the client or not at all.

Also, we should probably use Preconditions.checkArgument(foo, msg);, since this is part of the Guava idiom, and add throws IllegalArgumentException to function signatures that assert precondtions.

@bootstraponline
Copy link
Member

👍 for guava preconditions

@TikhomirovSergey
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants