Avoid enforcing the platform name while creating drivers #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
changed the title
KazuCocoa
approved these changes
Jun 24, 2019
| */ | ||
| protected static Capabilities setDefaultPlatformName(Capabilities originalCapabilities, | ||
| String newPlatform) { | ||
| if (originalCapabilities.getCapability(PLATFORM_NAME) == null) { |
SrinivasanTarget
approved these changes
Jun 25, 2019
mykola-mokhnach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Addresses #1162
Types of changes
Details
I hope the change won't affect much clients, but the current logic there is anyway incorrect and must be fixed.