Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting API should accept String type #1240

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Setting API should accept String type #1240

merged 1 commit into from
Sep 23, 2019

Conversation

takeyaqa
Copy link
Contributor

Change list

Java-client Setting API setSetting(Setting, Object) only accepts enum Setting. It's good for type safe. But, when new settings are added on server, user cannot use it until client update. I think this API should be more flexible.

I propose that Setting API can also accept String type like capabilities.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

* add overload method setSetting
* add test
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was thinking about adding this method

@mykola-mokhnach mykola-mokhnach merged commit f11fe00 into appium:master Sep 23, 2019
@takeyaqa takeyaqa deleted the settings_by_string branch September 24, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants