Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid throwing null pointer exception if any of settings is equal to null #1241

Merged
merged 1 commit into from
Sep 24, 2019
Merged

fix: Avoid throwing null pointer exception if any of settings is equal to null #1241

merged 1 commit into from
Sep 24, 2019

Conversation

mykola-mokhnach
Copy link
Contributor

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Recently Appium started retuning null as setting value. This breaks ImmutableMap implementation, which does not allow nulls as values.
Addresses https://dev.azure.com/srinivasansekar/java-client/_build/results?buildId=290&view=ms.vss-test-web.build-test-results-tab&runId=1000428&resultId=100049&paneView=debug

@mykola-mokhnach mykola-mokhnach merged commit 53814cd into appium:master Sep 24, 2019
@mykola-mokhnach mykola-mokhnach deleted the null_map branch September 24, 2019 05:26
@mykola-mokhnach mykola-mokhnach mentioned this pull request Sep 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@SrinivasanTarget SrinivasanTarget Awaiting requested review from SrinivasanTarget SrinivasanTarget is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mykola-mokhnach @KazuCocoa