Feat: Add support for viewmatcher #1293
Conversation
|
Chanatan Charnkijtawarush seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Add support for viewmatcher along with test for datamatcher
ccharnkij
force-pushed
the
add-viewmatcher
branch
from
c87c8d7
to
0f2ca58
Compare
| @@ -106,6 +106,17 @@ public static By androidDataMatcher(final String dataMatcherString) { | |||
| return new ByAndroidDataMatcher(dataMatcherString); | |||
| } | |||
|
|
|||
| /** | |||
| * This locator strategy is only available in Espresso Driver mode. | |||
| * @param viewMatcherString is a valid class chain locator string. | |||
There was a problem hiding this comment.
The sin of copy & paste...I got it from the dataMatcher. I'll add a new commit in real quick, for the dataMatcher too. My apologies...
|
Please sign the CLA, so we could merge the PR. Thanks |
Fix method doc for dataMatcher and viewMatcher
|
I believe the cla check is good. |
the bot verifies the email address set to your local git config and compares it with the one used for CLA signing. Just make sure you created the PR using the correct local email |
|
The PR is fine, but I unfortunately cannot merge it unless the bot confirms the CLA is signed. Make sure the email address in your local github config is correct and recreate the PR |
|
@mykola-mokhnach Doesn't this mean that the bot successfully confirms CLA is signed?
|
|
yes, this looks good. Although it is still weird why the bot didn't change the first comment. @jlipps do you know what the expected behaviour is? |
|
Yeah expected behavior is only to approve the fixed commit. As long as the PR is green we should be good to go |
|
ok, thanks for checking this @jlipps |
Change list
Per appium/appium#13747, add support for viewmatcher along with test for datamatcher
Types of changes
Details
Similar to dataMatcher, provides a functionality for viewMatcher. Also I noticed that dataMatcher had no test, so I added one for dataMatcher as well.