Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change getDeviceTime to call the mobile implementation #1332

Merged
merged 2 commits into from
Apr 4, 2020

Conversation

mykola-mokhnach
Copy link
Contributor

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Selenium webdriver implementation ignores parameters passed into GET requests. This PR replaces the call with parameters with the corresponding mobile: endpoint implementation to make it working properly. See appium/appium#14141

@markbearden
Copy link

markbearden commented May 4, 2021

Informational note: The main Appium documentation for the system_time endpoint, and the Appium-hosted copy of the Java client's getDeviceTime(), do not yet indicate any support for the "format" parameter that this change is adding. (I am wondering from where came the expectation that the client could ask the Appium server to format the time response, when that appears to have never been supported/documented for the Appium server? The source of this request, other than the issue reporter's assumption, is not explicitly indicated either here or at appium/appium#14141; that is, what specification was being complied with by making this change to the Java Appium client?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants