refactor: Use the new session payload creator inherited from Selenium #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into appium_payload_rm # Conflicts: # src/main/java/io/appium/java_client/remote/AppiumCommandExecutor.java
mykola-mokhnach
changed the title
mykola-mokhnach
changed the title
valfirst
approved these changes
Oct 21, 2021
SrinivasanTarget
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
The
NewAppiumSessionPayloadis very hacky and also hard to read. It basically copies the most ofNewSessionPayloadSelenium class while adding some specific workarounds on top of that. The idea is to get rid of it and use the original implementation from Selenium as we don't want or need to do jwp->w3c conversion anymore. Also removed the obsoleteFORCE_MJSONWPcapability.Types of changes