refactor: change prefix to AppiumBy in locator toString implement…
#1559
Conversation
| * @return an instance of {@link MobileBy.ByWindowsAutomation} | ||
| */ | ||
| @Deprecated | ||
| public static By windowsAutomation(final String windowsAutomation) { |
There was a problem hiding this comment.
this change is needed to keep backward compatibility: ByWindowsAutomation#toString should return the result in old format
There was a problem hiding this comment.
I'm not quite sure if we need this locator type at all. I did not hear about some special Windows location strategies that are different from these that Selenium supports.
There was a problem hiding this comment.
I think the windows driver is not in active development for an year now and they are still in JWP and not in W3C.
There was a problem hiding this comment.
I'm not an expert in windows test automation at all, so should I remove this locator at all? or should I just remove this piece of deprecations?
There was a problem hiding this comment.
I would say we remove it from AppiumBy interface and add a comment about that to the legacy one. Although I'd like to confirm that with our Windows expert @akinsolb first (e.g. does dotnet client expose such locator and if yes then for which purpose it is used)?
There was a problem hiding this comment.
RE #462 It's amazing that java, ruby and python have reference to that -windows uiautomation and the server doesn't. I'll mark it as obsolete for the next release
There was a problem hiding this comment.
Oh, i see. will mark it as deprecated
valfirst
force-pushed
the
add-lost-changes
branch
from
595da74
to
a54e7cc
Compare
Change list
Adds lost changes addressing the review comment: #1538 (comment)
Types of changes
What types of changes are you proposing/introducing to Java client?
Details
Change the prefix from
By.toAppiumBy.in locatortoStringimplementation.