chore: Include more tests into the pipeline #1566
Conversation
| jdkArchitectureOption: 'x64' | ||
| publishJUnitResults: true | ||
| tasks: 'build' | ||
| options: 'miscTest -x checkstyleTest -x test -x signMavenJavaPublication' |
There was a problem hiding this comment.
| options: 'miscTest -x checkstyleTest -x test -x signMavenJavaPublication' | |
| options: 'miscTest -x checkstyleTest -x test' |
it seems exclusion of signMavenJavaPublication is not needed anymore
There was a problem hiding this comment.
was not sure about this one. How do you see it's not needed?
There was a problem hiding this comment.
I'm running it locally without exclusion and it doesn't fail
There was a problem hiding this comment.
but CI could differ, so it's just my assumption
There was a problem hiding this comment.
Created PR to check the assumption: #1568, all builds are passed.
mykola-mokhnach
changed the title
… into align_tests
mykola-mokhnach
changed the title
mykola-mokhnach
changed the title
| @@ -33,6 +35,11 @@ public BaseMapOptionData(Map<String, Object> options) { | |||
| this.options = options; | |||
| } | |||
|
|
|||
| public BaseMapOptionData(String json) { | |||
| //noinspection unchecked | |||
| this((Map<String, Object>) new Gson().fromJson(json, Map.class)); | |||
There was a problem hiding this comment.
I guess it would be better to convert Gson object to a static field and reuse it here and in methods toJson() and toString()
| @Test | ||
| public void canBuildXcuiTestOptions() throws MalformedURLException { | ||
| XCUITestOptions options = new XCUITestOptions(); | ||
| assertEquals(options.getPlatformName(), Platform.IOS); |
There was a problem hiding this comment.
asssertEquals accepts expected as the first parameter and actual as the second parameter
There was a problem hiding this comment.
and it seems it's relevant to all assertions in this class
… into align_tests # Conflicts: # azure-pipelines.yml
Change list
Some tests exist but never get executed by the CI.
Types of changes