-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: relax constraints of Selenium dependencies versions #1606
build: relax constraints of Selenium dependencies versions #1606
Conversation
We could try that, although there were already issues about several breaking selenium API updates because of incompatible changes in their API. Basically the question is how big is the probability that the next selenium version (minor, major or patch) is going to be incompatible to the current Appium client. And from my perspective such probability could be pretty high, since we don't only use public APIs, but rather perform many reflective calls to private/protected stuff and hack selenium lib here and there. |
Maybe for now we could declare a strict version range like in https://docs.gradle.org/current/userguide/single_versions.html (Example 2):
|
7af7ff8
to
ac02157
Compare
@mykola-mokhnach thank you for your comments, I really appreciate them, I've updated the PR following your hints |
ac02157
to
06fedd1
Compare
https://docs.gradle.org/current/userguide/dependency_downgrade_and_exclude.html: "conflicting strict dependencies will trigger a build failure that you have to resolve". An attempt to use `java-client:8.0.0-beta` in conjunction with Selenium 4.1.0 leads to build failures, like: ``` > Could not resolve org.seleniumhq.selenium:selenium-remote-driver:{strictly 4.0.0}. Required by: project :xxxxxxx > io.appium:java-client:8.0.0-beta ``` In a favor of flexibility the constraints of selenium dependencies versions are relaxed.
06fedd1
to
bc72fec
Compare
Change list
In a favor of flexibility the constraints of selenium dependencies versions are relaxed.
Types of changes
What types of changes are you proposing/introducing to Java client?
Details
https://docs.gradle.org/current/userguide/dependency_downgrade_and_exclude.html: "conflicting strict dependencies will trigger a build failure that you have to resolve".
An attempt to use
java-client:8.0.0-beta
in conjunction with Selenium 4.1.0 leads to build failures, like:In a favor of flexibility the constraints of selenium dependencies versions are relaxed.