Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Remove obsolete event firing decorators #1676

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

BREAKING CHANGES:

  • Removed previously deprecated legacy Spring-based event decorators in favour of the Selenium's built-in one

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@valfirst
Copy link
Collaborator

valfirst commented Apr 4, 2022

Does it make sense to add a note on breaking changes to the migration guide?

@mykola-mokhnach
Copy link
Contributor Author

Does it make sense to add a note on breaking changes to the migration guide?

It's already there. The related stuff has been already marked as deprecated and now it's time to remove it completely for good (and publish in the next minor lib version)

@mykola-mokhnach mykola-mokhnach merged commit 2102e3d into appium:master Apr 4, 2022
@mykola-mokhnach mykola-mokhnach deleted the rm_spring branch April 4, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants