Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated spell for BYACCESSABILITY to BYACCESSIBILITY strategies enum #1752

Merged

Conversation

bipin-k
Copy link
Contributor

@bipin-k bipin-k commented Aug 26, 2022

Change list

Please provide briefly described change list which are you going to propose.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Updated spelling for BYACCESSABILITY to BYACCESSIBILITY strategies enum

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 26, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bipin-k / name: Bipin Kumar Chaurasia (125a296)

@mykola-mokhnach
Copy link
Contributor

This might be a breaking change. Please add a properly spelled item, but keep the old one and mark it deprecated. Also add a deprecation comment there and advice to switch to the correctly spelled one.

@mykola-mokhnach
Copy link
Contributor

Also please change the pull request name to follow https://www.conventionalcommits.org/en/v1.0.0/ spec

@bipin-k bipin-k force-pushed the accessibility-strategy-fixes branch from 3268c05 to 36fc371 Compare August 30, 2022 08:23
@bipin-k
Copy link
Contributor Author

bipin-k commented Aug 30, 2022

This might be a breaking change. Please add a properly spelled item, but keep the old one and mark it deprecated. Also add a deprecation comment there and advice to switch to the correctly spelled one.

@mykola-mokhnach This has been done, please have a look.

@bipin-k bipin-k force-pushed the accessibility-strategy-fixes branch from f4d947c to 2574c42 Compare August 30, 2022 11:21
@SrinivasanTarget SrinivasanTarget merged commit c9a5c92 into appium:master Aug 30, 2022
@bipin-k bipin-k deleted the accessibility-strategy-fixes branch August 30, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants