Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary annotation #1791

Merged
merged 3 commits into from
Nov 3, 2022
Merged

chore: remove unnecessary annotation #1791

merged 3 commits into from
Nov 3, 2022

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Nov 3, 2022

Change list

The accessors annotation can be removed when it has no arguments.

> Task :compileJava
/Users/kazu/GitHub/java-client/src/main/java/io/appium/java_client/remote/DirectConnect.java:16: warning: Accessors on its own does nothing. Set at least one parameter
@Accessors
^

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

It seems like the annotation is used only when we'd like to set non-default options
https://github.com/projectlombok/lombok/blob/560ded50127b12bd8168f8ae2bada47253f15bc8/src/core/lombok/core/AnnotationValues.java#L570

(i have tested without this annotation)

@@ -13,7 +29,6 @@

import static io.appium.java_client.internal.CapabilityHelpers.APPIUM_PREFIX;

@Accessors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the appropriate import sill used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope its unused, it should be removed.

@KazuCocoa KazuCocoa merged commit 8f6e2cf into master Nov 3, 2022
@KazuCocoa KazuCocoa deleted the remove-annotation branch November 3, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants