add apis for recording the screen #606
Conversation
|
@SrinivasanTarget Why is this on hold? Is there lack of functuinality on the server side? @heeseon could you provide some tests? |
Yes |
|
@saikrishna321 Hi. Is there any update on the server side to try to test/merge this PR? It seems related issues were closed. |
|
@TikhomirovSergey Its here now appium/appium-android-driver#218. Not yet complete at server end. |
|
Its here now appium/appium-android-driver#218 completed. please review this PR. |
|
Meanwhile can you fix the merge conflicts @heeseon |
|
I fixed the merge conflicts. |
There was a problem hiding this comment.
@heeseon Hi
Sorry for the late response. Could you provide some test to be sure that everything is ok)
| @@ -151,7 +156,10 @@ | |||
| postC("/session/:sessionId/appium/performanceData/types")); | |||
| commandRepository.put(GET_PERFORMANCE_DATA, | |||
| postC("/session/:sessionId/appium/getPerformanceData")); | |||
|
|
|||
| commandRepository.put(START_RECORDING_SCREEN, | |||
| postC("/session/:sessionId/appium/startRecordingScreen")); | |||
There was a problem hiding this comment.
There is a change in API here, so update here accordingly as start_recording_screen or else it will throw unsupported command exception.
There was a problem hiding this comment.
I request to change from start_recording_screen to startRecordingScreen
There was a problem hiding this comment.
@heeseon Didn't get you? It was changed in server side as per standards or convention appium follows.
| commandRepository.put(START_RECORDING_SCREEN, | ||
| postC("/session/:sessionId/appium/startRecordingScreen")); | ||
| commandRepository.put(STOP_RECORDING_SCREEN, | ||
| postC("/session/:sessionId/appium/stopRecordingScreen")); |
There was a problem hiding this comment.
Same here stop_recording_screen
There was a problem hiding this comment.
I request to change from stop_recording_screen to stopRecordingScreen
heeseon
force-pushed
the
readperformancedata
branch
from
6c372d7
to
28418b6
Compare
|
@TikhomirovSergey I added test case ^^ |
|
for the codacy-bot comment 22 days ago how I can resolve this? |
|
@heeseon Simply move the string to a constant. Also, there are many conflicts there. Please rebase your branch with recent master. |
…-client into readperformancedata
…-client into readperformancedata * 'readperformancedata' of https://github.com/heeseon/java-client: (156 commits) build error Do not hardcode Do not hardcode Update README.md Update README.md Code style issues which were found by reviewer were fixed Code style issues which were found by reviewer were fixed The addition to appium#738 - following dependencies were updated: `org.seleniumhq.selenium:selenium-java` to 3.6.0 `com.google.code.gson:gson` to 2.8.2 `org.springframework:spring-context` to 5.0.0.RELEASE `org.aspectj:aspectjweaver` to 1.8.11 do not zero out implicit wait during location call rename DEFAULT_IMPLICITLY_WAIT_TIMEOUT to DEFAULT_TIMEOUT Update README.md some minor things that were found by reviewers were improved code style issues were got fixed appium#732 FIX ServerBuilderTest: ip calculation was improved ServerBuilderTest: the path resolving ServerBuilderTest: magic strings were turned into final values ServerBuilderTest: magic strings were turned into final values ServerBuilderTest: code improvement. Tests of local appium DriverService were re-designed. ...
|
Replaced by #814 |
Change list
add apis for recording the screen
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
I added three apis for recording the screen
add apis for recording the screen appium-base-driver#110
add apis for recording the screen appium-android-driver#216