New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#655 FIX #682

Merged
merged 5 commits into from Aug 5, 2017

Conversation

Projects
None yet
4 participants
@TikhomirovSergey
Member

TikhomirovSergey commented Jul 31, 2017

Change list

#655 FIX

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

io.appium.java_client.remote.AppiumCommandExecutor was rolled back.

It is breaking change because it is compatible with appium server > v1.6.5

@TikhomirovSergey TikhomirovSergey added this to the 5.0.0 milestone Jul 31, 2017

@TikhomirovSergey TikhomirovSergey self-assigned this Jul 31, 2017

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey
Member

TikhomirovSergey commented Jul 31, 2017

@mykola-mokhnach

This comment has been minimized.

Show comment
Hide comment
@mykola-mokhnach

mykola-mokhnach Aug 1, 2017

Contributor

How about having some unit test to verify resulting capabilities structure?

Contributor

mykola-mokhnach commented Aug 1, 2017

How about having some unit test to verify resulting capabilities structure?

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Aug 1, 2017

Member

@mykola-mokhnach

How about having some unit test to verify resulting capabilities structure?

I think we don't need for these tests:

  1. as you can see public class AppiumCommandExecutor extends HttpCommandExecutor and
 @Override public Response execute(Command command) throws IOException, WebDriverException {
        ...
      return super.execute(command);
       ...
   }
  1. The capability forming is fully inherited from Selenium
    HttpCommandExecutor ProtocolHandshake

Our tests which run some AppiumDriver are successful.

Member

TikhomirovSergey commented Aug 1, 2017

@mykola-mokhnach

How about having some unit test to verify resulting capabilities structure?

I think we don't need for these tests:

  1. as you can see public class AppiumCommandExecutor extends HttpCommandExecutor and
 @Override public Response execute(Command command) throws IOException, WebDriverException {
        ...
      return super.execute(command);
       ...
   }
  1. The capability forming is fully inherited from Selenium
    HttpCommandExecutor ProtocolHandshake

Our tests which run some AppiumDriver are successful.

@appium appium deleted a comment from codacy-bot Aug 4, 2017

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Aug 4, 2017

Member

@mykola-mokhnach There is another one improvement.

Member

TikhomirovSergey commented Aug 4, 2017

@mykola-mokhnach There is another one improvement.

@mykola-mokhnach

This comment has been minimized.

Show comment
Hide comment
@mykola-mokhnach

mykola-mokhnach Aug 4, 2017

Contributor

there is no need to rename the var to show that it's optional - we anyway have static typing

there is no need to rename the var to show that it's optional - we anyway have static typing

@mykola-mokhnach

This comment has been minimized.

Show comment
Hide comment
@mykola-mokhnach

mykola-mokhnach Aug 4, 2017

Contributor

is it mandatory to explicitly define the type? same question to the mapping below

is it mandatory to explicitly define the type? same question to the mapping below

@mykola-mokhnach

This comment has been minimized.

Show comment
Hide comment
@mykola-mokhnach
Contributor

mykola-mokhnach commented Aug 4, 2017

@appium appium deleted a comment from codacy-bot Aug 4, 2017

@codacy-bot

This comment has been minimized.

Show comment
Hide comment
@codacy-bot

codacy-bot Aug 5, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ src/main/java/io/appium/java_client/remote/AppiumCommandExecutor.java  -18
         

See the complete overview on Codacy

codacy-bot commented Aug 5, 2017

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ src/main/java/io/appium/java_client/remote/AppiumCommandExecutor.java  -18
         

See the complete overview on Codacy

@appium appium deleted a comment from codacy-bot Aug 5, 2017

@TikhomirovSergey TikhomirovSergey merged commit e0e5ae0 into appium:master Aug 5, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment