New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#696 FIX #699

Merged
merged 3 commits into from Aug 24, 2017

Conversation

Projects
None yet
5 participants
@TikhomirovSergey
Member

TikhomirovSergey commented Aug 20, 2017

Change list

  • changes from the #698
  • selenium-java was updated to 3.5.x
  • org.apache.commons-lang3 was updated to 3.6
  • org.springframework.spring-context was updated to 4.3.10.RELEASE
  • the element genering was improved. #696 FIX
  • some improvements of AppiumDriver#context

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

I suppose that it is the last change and we should publish 5.0.0. All the pended pull-requests will be merged and published at 5.1.0

mykola-mokhnach and others added some commits Aug 19, 2017

#696 FIX:
 - changes from the #698
 - selenium-java was updated to 3.5.1
 - org.apache.commons-lang3 was updated to 3.6
 - org.springframework.spring-context was updated to 4.3.10.RELEASE
 - the element genering was improved. #696 FIX
 - some improvements of AppiumDriver#context
Show outdated Hide outdated build.gradle
@mykola-mokhnach

This comment has been minimized.

Show comment
Hide comment
@mykola-mokhnach

mykola-mokhnach Aug 20, 2017

Contributor

[ant:checkstyle] [ERROR] /home/travis/build/appium/java-client/src/main/java/io/appium/java_client/AppiumDriver.java:215:9: '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). [RightCurly]
:checkstyleMain FAILED

Contributor

mykola-mokhnach commented Aug 20, 2017

[ant:checkstyle] [ERROR] /home/travis/build/appium/java-client/src/main/java/io/appium/java_client/AppiumDriver.java:215:9: '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). [RightCurly]
:checkstyleMain FAILED

@mykola-mokhnach mykola-mokhnach referenced this pull request Aug 20, 2017

Closed

Address compilation error with selenium 3.5.1 #698

1 of 4 tasks complete
@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey

TikhomirovSergey Aug 20, 2017

Member

@mykola-mokhnach
Yes I know about the check style issue and I will get it fixed ASAP

Member

TikhomirovSergey commented Aug 20, 2017

@mykola-mokhnach
Yes I know about the check style issue and I will get it fixed ASAP

@TikhomirovSergey

This comment has been minimized.

Show comment
Hide comment
@TikhomirovSergey
Member

TikhomirovSergey commented Aug 23, 2017

@mykola-mokhnach @SrinivasanTarget I have updated this PR

@mykola-mokhnach

This comment has been minimized.

Show comment
Hide comment
@mykola-mokhnach

mykola-mokhnach Aug 24, 2017

Contributor

Yep, now the PR looks much better. @TikhomirovSergey please merge it

Contributor

mykola-mokhnach commented Aug 24, 2017

Yep, now the PR looks much better. @TikhomirovSergey please merge it

@TikhomirovSergey TikhomirovSergey merged commit f96b165 into appium:master Aug 24, 2017

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@zyou1986

This comment has been minimized.

Show comment
Hide comment
@zyou1986

zyou1986 Aug 28, 2017

group 'io.appium'
version '5.0.0'
ext.seleniumVersion = '3.5.+'

Excuse me, sir,I downloaded the latest project,and update build gradle,but I have this problem:

Error:(44, 42) java: io.appium.java_client.MobileElement中的findElements(org.openqa.selenium.By)无法覆盖org.openqa.selenium.remote.RemoteWebElement中的findElements(org.openqa.selenium.By)
  返回类型java.util.List<io.appium.java_client.MobileElement>与java.util.List<org.openqa.selenium.WebElement>不兼容
~~~~~~~~~~~~~~~
Could you tell me how to solve it?

zyou1986 commented on 577b030 Aug 28, 2017

group 'io.appium'
version '5.0.0'
ext.seleniumVersion = '3.5.+'

Excuse me, sir,I downloaded the latest project,and update build gradle,but I have this problem:

Error:(44, 42) java: io.appium.java_client.MobileElement中的findElements(org.openqa.selenium.By)无法覆盖org.openqa.selenium.remote.RemoteWebElement中的findElements(org.openqa.selenium.By)
  返回类型java.util.List<io.appium.java_client.MobileElement>与java.util.List<org.openqa.selenium.WebElement>不兼容
~~~~~~~~~~~~~~~
Could you tell me how to solve it?
@ukostas

This comment has been minimized.

Show comment
Hide comment
@ukostas

ukostas Jan 2, 2018

hi @mykola-mokhnach , I have a problem with this line if I use Widget class which has declared locator annotated with FindBy (web locator). Looks like if widget class itself is annotated (not as a field in page object) then variable annotatedElement is a Class and cannot be casted to Field. Could you please review implementation ? Let me know if I should log a separate issue for this. thanks .

hi @mykola-mokhnach , I have a problem with this line if I use Widget class which has declared locator annotated with FindBy (web locator). Looks like if widget class itself is annotated (not as a field in page object) then variable annotatedElement is a Class and cannot be casted to Field. Could you please review implementation ? Let me know if I should log a separate issue for this. thanks .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment