#714 FIX #717
#714 FIX #717
Conversation
| @@ -21,8 +21,6 @@ | |||
| import static io.appium.java_client.pagefactory.ThrowableUtil.isStaleElementReferenceException; | |||
|
|
|||
|
|
|||
| import com.google.common.base.Function; | |||
There was a problem hiding this comment.
I also see this import in several other sources - are they all expected?
There was a problem hiding this comment.
@mykola-mokhnach No
Except the AppiumFunction class. I improved sourses at my last commit
| @@ -54,14 +54,18 @@ compileJava { | |||
| ] | |||
| } | |||
|
|
|||
| ext.seleniumVersion = '[3.5.2,3.5.2]' | |||
| ext.seleniumVersion = '[3.5.3,3.5.3]' | |||
There was a problem hiding this comment.
what is the point to set a range, which includes only one item? Isn't it simply equal to '3.5.3'?
There was a problem hiding this comment.
@mykola-mokhnach The purpose is to make a valid pom.xml file. The version like 3.5+ is malformed for maven.
|
I was also thinking about enforcing the version of guava library, since our module cannot work if it is older than 20 |
|
@TikhomirovSergey As @mykola-mokhnach suggested i think we should force |
|
@SrinivasanTarget I will try it with the |
| } | ||
|
|
||
| return result; | ||
| if (result.size() == 0) { |
There was a problem hiding this comment.
return result.isEmpty() ? null : result;
|
@SrinivasanTarget I think it is not necessary to force the https://mvnrepository.com/artifact/org.seleniumhq.selenium/selenium-remote-driver/3.5.3 |
Ok |
Change list
Types of changes
Details
Dependencies of the html unit driver
https://mvnrepository.com/artifact/org.seleniumhq.selenium/htmlunit-driver/2.27
Dependencies of the phantom js driver
https://mvnrepository.com/artifact/com.codeborne/phantomjsdriver/1.4.3
Also something weird was foaund in AppiumElementLocator. I wonder why we couldn't find it before.