New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit the default process environment by default #753

Merged
merged 2 commits into from Oct 23, 2017

Conversation

Projects
None yet
3 participants
@mykola-mokhnach
Contributor

mykola-mokhnach commented Oct 13, 2017

Change list

I see many people are struggling because of the fact that we set an empty environment by default while building Appium executor. This causes Appium drivers to fail unexpectedly since they cannot find executables that are supposed to available in PATH. This PR adds all the inherited process env variable to the builder by default.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@TikhomirovSergey TikhomirovSergey merged commit 9c973d3 into appium:master Oct 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mykola-mokhnach mykola-mokhnach deleted the mykola-mokhnach:default_env branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment