Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor setting of touch actions options #756
The idea of this PR is to unify touch action options, so it is easier to extend them.
Types of changes
changed the title from
Refactor setting touch actions options
Refactor setting of touch actions options
Oct 16, 2017
I generally like this PR and the idea behind it. But I have some doubds:
- why there some empty classes? May some things be generilized?
- is it safe to declare something like
public T waitAction(ActionOptions waitOptions)? What is user will try something like
to.wait(optionsWithAbsolutePositioning)? Should methods have more strict signature?
See my comment above about builder generics. Also, it will be possible to add more stuff into these classes later, for example some special platform-specific gestures, which we don't support yet.
I thought about it... From code creation perspective the current approach should not be a problem, since it's pretty obvious to see an error in the method like