Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init web socket clients lazily #912

Merged
merged 1 commit into from
May 25, 2018

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

It looks like web socket lib throws an exception on init for some reason. So it would be safer to init the stuff lazily in order to avoid the java class loader from throwing this exception each time when the driver is instantiated.

See https://stackoverflow.com/questions/50293463/appium-test-case-throws-exception for the reference.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach mykola-mokhnach merged commit 95f0964 into appium:master May 25, 2018
@mykola-mokhnach mykola-mokhnach deleted the websocket_lazy branch May 31, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants