Flake8 black changes #803
Closed
Flake8 black changes #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed unnecessary inheritance from object - removed unnecessary u prefix for strings - sorted some imports - converted strings into f-strings - simplified a conditional
A simple way of consistently tidying the codebase.
|
black formatting is already applied to the codebase |
|
Line 14 in 91a9d67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the black formatter over the codebase. There are some wins here in that it fixes a lot of style issues, tidies imports and consistently lays out the codebase.
Ideally this could be added to github actions or pre_commit.
All tests were re-run and no additional failures identified.