chore: remove duplicated clean command #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KazuCocoa
commented
Dec 13, 2022
•
KazuCocoa
commented
- clear command exists in the selenium client, so it is safe to remove it from this library. Maybe.... the original motivation to add this endpoint was to add the command for MJSONWP.
- https://github.com/SeleniumHQ/selenium/blob/084c3b16bb11d625536141bc441ec95a8ee05bb7/py/selenium/webdriver/remote/webelement.py#L114-L116
- https://github.com/SeleniumHQ/selenium/blob/084c3b16bb11d625536141bc441ec95a8ee05bb7/py/selenium/webdriver/remote/remote_connection.py#L204
- The removed one should not be an issue since at least, v4, is the below at least
KazuCocoa
changed the title
mykola-mokhnach
approved these changes
Jun 8, 2023
|
@KazuCocoa I think I know the reason why this override has been present there: https://discuss.appium.io/t/clear-is-not-working-anymore-what-is-the-alternative/39421/5 The original API in selenium returns None while the overridden one returns the self instance, so chaining could be possible |
|
oh, i see. Then, let me rever this change and leave it as a comment |
KazuCocoa
added a commit
that referenced
this pull request
Jun 13, 2023
This reverts commit 2f45ef9.
KazuCocoa
added a commit
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.