docs: address options in the migration guide #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -60,6 +60,9 @@ For example, some changes in the Selenium binding could break the Appium client. | |||
|
|
|||
|
|
|||
| ### Quick migration guide from v2 to v3 | |||
| - `options` keyword argument for `webdriver.Remote` such as `XCUITestOptions` instead of `desired_capabilities` | |||
| - Available options are https://github.com/appium/python-client/tree/master/appium/options | |||
| - Not "new" change, but the `desired_capabilities` has been removed since v3. | |||
There was a problem hiding this comment.
typo below properly -> property
README.md
Outdated
| @@ -60,6 +60,9 @@ For example, some changes in the Selenium binding could break the Appium client. | |||
|
|
|||
|
|
|||
| ### Quick migration guide from v2 to v3 | |||
| - `options` keyword argument for `webdriver.Remote` such as `XCUITestOptions` instead of `desired_capabilities` | |||
There was a problem hiding this comment.
for webdriver.Remote -> in the webdriver.Remote contructor
| @@ -60,6 +60,9 @@ For example, some changes in the Selenium binding could break the Appium client. | |||
|
|
|||
|
|
|||
| ### Quick migration guide from v2 to v3 | |||
| - `options` keyword argument for `webdriver.Remote` such as `XCUITestOptions` instead of `desired_capabilities` | |||
| - Available options are https://github.com/appium/python-client/tree/master/appium/options | |||
There was a problem hiding this comment.
we may also link the example code below where options are used
README.md
Outdated
| - `options` keyword argument in the `webdriver.Remote` constructor such as `XCUITestOptions` instead of `desired_capabilities` | ||
| - Available options are https://github.com/appium/python-client/tree/master/appium/options | ||
| - Please check the [Usage](#usage) below as an exampple. | ||
| - Not a "new" change, but the `desired_capabilities` has been removed since v3. |
There was a problem hiding this comment.
the desired_capabilities argument
mykola-mokhnach
approved these changes
Oct 18, 2023
KazuCocoa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a couple of times about this
optionsargument report these days. Lets address it in the migration guide since v3 completely removed the old desired_capabilities