Skip to content
This repository has been archived by the owner on Mar 23, 2020. It is now read-only.

Upgrade ios-simple to use Appium 1.6.0 #102

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Conversation

dpgraham
Copy link
Contributor

-Replaced elementByIosUIAutomation call with elementByAccessibilityId because we use the appium-xcui-test-driver which doesn't support UIAutomation
-Upgraded appium-version in desiredCapabilities config file (caps.js) to version 1.6

@jlipps
Copy link
Contributor

jlipps commented Oct 26, 2016

@dpgraham it looks like your git user isn't set up with the same e-mail as your github user, mind fixing that and re-committing? code LGTM

@imurchie
Copy link
Contributor

Moving forward can you put the language in the title, too (ios-simple exists in a number of the languages in this repo)? Looks good, otherwise!

Copy link
Contributor

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment then LGTM

@@ -0,0 +1,46 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably don't want to commit visual studio code files. my suggestion would be to add this to your global .gitignore

@jlipps
Copy link
Contributor

jlipps commented Oct 28, 2016

Oh, @dpgraham looks like your machine's github user is still not set up to use the same one as @dpgraham on github

@jlipps
Copy link
Contributor

jlipps commented Jan 30, 2017

@dpgraham mind repushing as your GH user, and cleaning up the launch.json file? then we can merge this.

@jsf-clabot
Copy link

jsf-clabot commented Feb 8, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Daniel Graham seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@dpgraham
Copy link
Contributor Author

dpgraham commented Feb 8, 2017

I've pushed to it with my new credentials.

@jlipps
Copy link
Contributor

jlipps commented Feb 8, 2017

@dpgraham it's still not working; somehow your old user is also attached on some of these commits. it might be better to just squash them so it all gets rewritten as your new user, and force-push to the PR branch?

@dpgraham
Copy link
Contributor Author

dpgraham commented Feb 9, 2017

Done. I squashed them together and reworded the commit message. Should be good now.

@jlipps jlipps merged commit e331b39 into master Feb 9, 2017
@jlipps jlipps deleted the dan-update-to-1_6_0 branch February 9, 2017 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants