-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Upgrade ios-simple to use Appium 1.6.0 #102
Conversation
@dpgraham it looks like your git user isn't set up with the same e-mail as your github user, mind fixing that and re-committing? code LGTM |
Moving forward can you put the language in the title, too ( |
0574138
to
dadfdfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment then LGTM
@@ -0,0 +1,46 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably don't want to commit visual studio code files. my suggestion would be to add this to your global .gitignore
Oh, @dpgraham looks like your machine's github user is still not set up to use the same one as |
@dpgraham mind repushing as your GH user, and cleaning up the |
006a072
to
0e1a171
Compare
Daniel Graham seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
I've pushed to it with my new credentials. |
@dpgraham it's still not working; somehow your old user is also attached on some of these commits. it might be better to just squash them so it all gets rewritten as your new user, and force-push to the PR branch? |
0e1a171
to
bbac3aa
Compare
bbac3aa
to
04b5ca9
Compare
Done. I squashed them together and reworded the commit message. Should be good now. |
-Replaced elementByIosUIAutomation call with elementByAccessibilityId because we use the appium-xcui-test-driver which doesn't support UIAutomation
-Upgraded appium-version in desiredCapabilities config file (caps.js) to version 1.6